Re: [PATCH v2 1/3] bisect: read run output from the open descriptor
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Jul 18, 2026, 16:24 UTC
- Message-ID
- <1139ae20-f08b-4cf2-b779-42328831e13e@kdbg.org>
- In-Reply-To
- <0de8b12f65530497320b6a4bca395dfd0556c959.1784312854.git.gitgitgadget@gmail.com>
Am 17.07.26 um 20:27 schrieb Harald Nordgren via GitGitGadget:
> "git bisect run" redirects each step's output into BISECT_RUN, then > prints it back by reopening the file by name. Read it from the already > open descriptor instead; this behaves the same and no longer needs the > file to be reachable by name.
This rings alarm bells. Why would an open file not be reachable by name anymore? Are we already progressed sufficiently in our Windows port that it is possible to remove open files? Because it is (was?) the case that on Windows, open files cannot be remove, so this shouldn't happen anywhere in the code in general.
-- Hannes