Re: [GSoC][PATCH v8 00/10] clone: dir-iterator refactoring with tests

From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date: Jul 11, 2019, 15:24 UTC
Message-ID: <CAHd-oW7jwkHXjpExZOsP3OfJN4HP2ZmLR5h+NphovYoShC2OVQ@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1907111355360.47@tvgsbejvaqbjf.bet>

On Thu, Jul 11, 2019 at 8:56 AM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 10 quoted lines

>
> Hi Matheus,
>
> On Wed, 10 Jul 2019, Matheus Tavares wrote:
>
> > - a replacement of explicit recursive dir iteration at
> >   copy_or_link_directory for the dir-iterator API;
>
> As far as I can see, it was not replaced, but just dropped. Which is
> good, as it will most likely address the CI failures.

You mean the circular symlink checker, right? Yes, it was dropped. At this item I was referring to a dir iteration code at builtin/clone.c (using opendir/readdir) which was replaced by the dir-iterator API.

> Thanks,
> Dscho