git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Git 2.30.0 and failed self tests

From
Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date
Jan 9, 2021, 14:07 UTC
Message-ID
<CAHd-oW63pduiFr1pXhNZnHnnovhSGh5K=z0AQ1RAwGvbObsL4Q@mail.gmail.com>
In-Reply-To
<CAH8yC8mmox3fZTRO7W44whHhT0aPcNUXxrBVg1R7ttwUfVgy1A@mail.gmail.com>
Hi, Jeff
On Sat, Jan 9, 2021 at 8:32 AM Jeffrey Walton <noloader@gmail.com> wrote:
Show 44 quoted lines
>
> Hi Everyone,
>
> I'm seeing a failed self test with 2.30.0 on Alpine Linux 3.10,
> x86_64. Alpine Linux uses Musl and BusyBox, so things may be a bit
> sideways because of them.
>
> *** t4129-apply-samemode.sh ***
> ok 1 - setup
> ok 2 - same mode (no index)
> ok 3 - same mode (with index)
> ok 4 - same mode (index only)
> ok 5 - mode update (no index)
> ok 6 - mode update (with index)
> ok 7 - mode update (index only)
> ok 8 - empty mode is rejected
> ok 9 - bogus mode is rejected
> not ok 10 - do not use core.sharedRepository for working tree files
> #
> #        git reset --hard &&
> #        test_config core.sharedRepository 0666 &&
> #        (
> #            # Remove a default ACL if possible.
> #            (setfacl -k newdir 2>/dev/null || true) &&
> #            umask 0077 &&
> #
> #            # Test both files (f1) and leading dirs (d)
> #            mkdir d &&
> #            touch f1 d/f2 &&
> #            git add f1 d/f2 &&
> #            git diff --staged >patch-f1-and-f2.txt &&
> #
> #            rm -rf d f1 &&
> #            git apply patch-f1-and-f2.txt &&
> #
> #            echo "-rw-------" >f1_mode.expected &&
> #            echo "drwx------" >d_mode.expected &&
> #            test_modebits f1 >f1_mode.actual &&
> #            test_modebits d >d_mode.actual &&
> #            test_cmp f1_mode.expected f1_mode.actual &&
> #            test_cmp d_mode.expected d_mode.actual
> #        )
> #
> # failed 1 among 10 test(s)

Do you happen to have a default ACL rule or the setgid bit set on the test directory (or a parent directory)? This test is currently failing under these circumstances, but there are already two patches that fix these issues:

https://lore.kernel.org/git/b734425e3235651e738e6eac47eae0db7db92e7e.1609861567.git.matheus.bernardino@usp.br/ https://lore.kernel.org/git/20201223114431.4595-1-adam@dinwoodie.org/

Thanks, Matheus

Previous: Jeffrey WaltonNext: Junio C Hamano
Message 6 of 7 in “Git 2.30.0 and failed self tests”
  1. Jeffrey WaltonJan 9, 2021
  2. Christian CouderJan 9, 2021
  3. Jeffrey WaltonJan 9, 2021
  4. Matheus Tavares BernardinoJan 9, 2021
  5. Jeffrey WaltonJan 9, 2021
  6. Matheus Tavares BernardinoJan 9, 2021
  7. Junio C HamanoJan 9, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.