Re: Git 2.30.0 and failed self tests
- From
Matheus Tavares Bernardino <matheus.bernardino@usp.br>
- Date
- Jan 9, 2021, 20:15 UTC
- Message-ID
- <CAHd-oW48jK7o_L06FR515JvYNB0ZRZ25TR0WktfEpCzgQMGAGw@mail.gmail.com>
- In-Reply-To
- <CAH8yC8kdOrramqggwQ0HBLpub8_+7N+kuvfaCHRokamKFjer4Q@mail.gmail.com>
On Sat, Jan 9, 2021 at 4:42 PM Jeffrey Walton <noloader@gmail.com> wrote:
Show 23 quoted lines
> > On Sat, Jan 9, 2021 at 7:44 AM Christian Couder > <christian.couder@gmail.com> wrote: > > > > On Sat, Jan 9, 2021 at 12:33 PM Jeffrey Walton <noloader@gmail.com> wrote: > > > > > I'm seeing a failed self test with 2.30.0 on Alpine Linux 3.10, > > > x86_64. Alpine Linux uses Musl and BusyBox, so things may be a bit > > > sideways because of them. > > > > When a test script fails, could you try going into the "t" directory, > > running the test script with -i -v -x and sending the output? > > > > > *** t4129-apply-samemode.sh *** > > > > For example you could run the above test script with: > > > > $ cd t > > $ ./t4129-apply-samemode.sh -i -v -x > > Thanks Christian and Matheus, > > Attached is the redirected output of t4129.
Thanks for sending the output. Yeah, the problem is that the test doesn't account for the presence of the setgid bit (which is inherited from a parent dir). Here is the relevant part:
+ diff -u d_mode.expected d_mode.actual --- d_mode.expected +++ d_mode.actual
@@ -1 +1 @@ -drwx------ +drwx--S--- error: last command exited with $?=1 A patch fixing this issue was already sent, and it is marked to be merged to next: https://lore.kernel.org/git/b734425e3235651e738e6eac47eae0db7db92e7e.1609861567.git.matheus.bernardino@usp.br/