git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git.c: fix sparse warning

From
Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date
Jun 3, 2020, 02:17 UTC
Message-ID
<CAHd-oW5gaaH9Tn9Xq99AgH41N30Lr6N3n+GC2j1XUiNKyvAbdA@mail.gmail.com>
In-Reply-To
<d9686e75-0792-33f7-dd70-3dc8ca6c4d66@ramsayjones.plus.com>
On Mon, Jun 1, 2020 at 8:27 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
Show 18 quoted lines
>
>
> Commit 4acc44d720 (config: add setting to ignore sparsity patterns in
> some cmds, 2020-05-27) adds an external symbol definition without a
> corresponding external symbol declaration. This causes sparse to
> complain: "symbol 'opt_restrict_to_sparse_paths' was not declared.
> Should it be static?".
>
> In order to suppress the warning, #include the 'sparse-checkout.h'
> header file, which contains the required extern declaration.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Matheus,
>
> If you need to re-roll your 'mt/grep-sparse-checkout' branch, could you
> please squash this into the relevant patch.
Sure! Thanks for catching this.
Previous: Ramsay Jones
Message 2 of 2 in “git.c: fix sparse warning”
  1. git.c: fix sparse warningRamsay Jones, Jun 1, 2020
  2. Matheus Tavares BernardinoJun 3, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.