From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date: Wed, 03 Jun 2020 02:17:24 GMT
Subject: Re: [PATCH] git.c: fix sparse warning
Message-ID: <CAHd-oW5gaaH9Tn9Xq99AgH41N30Lr6N3n+GC2j1XUiNKyvAbdA@mail.gmail.com>
In-Reply-To: <d9686e75-0792-33f7-dd70-3dc8ca6c4d66@ramsayjones.plus.com>

On Mon, Jun 1, 2020 at 8:27 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
>
>
> Commit 4acc44d720 (config: add setting to ignore sparsity patterns in
> some cmds, 2020-05-27) adds an external symbol definition without a
> corresponding external symbol declaration. This causes sparse to
> complain: "symbol 'opt_restrict_to_sparse_paths' was not declared.
> Should it be static?".
>
> In order to suppress the warning, #include the 'sparse-checkout.h'
> header file, which contains the required extern declaration.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Matheus,
>
> If you need to re-roll your 'mt/grep-sparse-checkout' branch, could you
> please squash this into the relevant patch.

Sure! Thanks for catching this.