Re: [PATCH] grep: follow conventions for printing paths w/ unusual chars

From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date: Apr 19, 2020, 06:27 UTC
Message-ID: <CAHd-oW4dkLMp3FYyRoRWVgcTMJ0oKnKfnK--3r_Mx9EfrLoEnQ@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.2004181655300.46@tvgsbejvaqbjf.bet>

Hi, Dscho

On Sat, Apr 18, 2020 at 11:57 AM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

>
> On Sat, 18 Apr 2020, Johannes Schindelin wrote:
> >
> > On Fri, 17 Apr 2020, Matheus Tavares wrote:

...

Show 21 quoted lines

> > >
> > > Reported-by: Greg Hurrell <greg@hurrell.net>
> > > Signed-off-by: Matheus Tavares <matheus.bernardino@usp.br>
> > > ---
> > >  Documentation/git-grep.txt |  6 +++--
> > >  builtin/grep.c             | 46 ++++++++++++++++++++++++++++----------
> > >  t/t7810-grep.sh            | 44 ++++++++++++++++++++++++++++++++++++
> > >  3 files changed, 82 insertions(+), 14 deletions(-)
> >
> > Unfortunately, this causes eight test failures on Windows:
> > https://dev.azure.com/gitgitgadget/git/_build/results?buildId=38023&view=ms.vss-test-web.build-test-results-tab
> >
> > Could you please have a look? I suspect that this has something to do with
> > those new tests needing the `FUNNYNAMES` prereq.
>
> I need this commit to fix it:
> https://github.com/git-for-windows/git/commit/7ca815e1ab89d6ffdb1a17b3cbacdf22a508d33c
>
> I'll paste it here, for your convenience:
>
> -- snipsnap --

Thanks for reporting and correcting the testing issue. I'll send a v2 with your patch squashed in.