git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Is git-am expected to honor core.sharedRepository?

From
Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date
Dec 3, 2020, 01:44 UTC
Message-ID
<CAHd-oW4bkQ6uDxY87D-8r0E+756unTzmY8eFv_99z=oN2nu16A@mail.gmail.com>
In-Reply-To
<xmqqim9jn9rn.fsf@gitster.c.googlers.com>
On Wed, Dec 2, 2020 at 7:06 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
>
> Matheus Tavares Bernardino <matheus.bernardino@usp.br> writes:
>
> > (For some background, I stumbled across this while considering using
> > safe_create_leading_directories() for a parallel-checkout patch. But
> > then I noticed it adjusts the directories' permissions based on the
> > setting and I was worried whether it could be user for checkout.)
>
> Forgot to respond to this part, but you are correct.
>
> Anything that tries to replace what is in entry.c must not trigger
> adjust_shared_perm() on files and directories in the working tree,
> and it is a no-no to call safe_create_leading_directories().

Got it, thanks. I've adjusted the parallel-checkout patch to use the _no_share() scld variant from mt/do-not-use-scld-in-working-tree.

Previous: Junio C Hamano
Message 17 of 17 in “Is git-am expected to honor core.sharedRepository?”
  1. Matheus Tavares BernardinoDec 1, 2020
  2. Junio C HamanoDec 1, 2020
  3. apply: don't use core.sharedRepository to create working tree filesMatheus Tavares, Dec 1, 2020
  4. Junio C HamanoDec 2, 2020
  5. Adam DinwoodieDec 19, 2020
  6. Junio C HamanoDec 19, 2020
  7. Adam DinwoodieDec 19, 2020
  8. Achim GratzDec 19, 2020
  9. Adam DinwoodieDec 19, 2020
  10. Achim GratzDec 19, 2020
  11. Adam DinwoodieDec 22, 2020
  12. Matheus Tavares BernardinoDec 22, 2020
  13. t4129: fix setfacl-related permissions failureAdam Dinwoodie, Dec 23, 2020
  14. Matheus Tavares BernardinoJan 9, 2021
  15. Junio C HamanoJan 9, 2021
  16. Junio C HamanoDec 2, 2020
  17. Matheus Tavares BernardinoDec 3, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.