git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] apply: don't use core.sharedRepository to create working tree files

From
AGAchim Gratz <stromeko@nexgo.de>
Date
Dec 19, 2020, 18:32 UTC
Message-ID
<87y2ht4pfr.fsf@Rainer.invalid>
In-Reply-To
<CA+kUOamDD_SDNLk3sPSwNAojrAAP+g38MjkfG4JMPRTGOVAKAQ@mail.gmail.com>
Adam Dinwoodie writes:
> To my surprise, the test fails if the worktree is under "/cygdrive",

/cygdrive is normally mounted with "posix=0", which only affects case sensitivity, so that isn't the reason for this particular fail. You should anyway not build a Cygwin package with that option in effect, instead create your own mount point for that directory (with "binary,user" options).

Show 6 quoted lines
> +++ diff -u f1_mode.expected f1_mode.actual
> --- f1_mode.expected    2020-12-19 16:50:20.169378700 +0000
> +++ f1_mode.actual      2020-12-19 16:50:20.249126000 +0000
> @@ -1 +1 @@
> --rw-------
> +-rw-rw-r--

You seemingly can't change the ACL and/or several mode bits and see the effective access that your euid / egid has instead. It is possible to set up the (default) ACL in a way that removes the permission to change them while otherwise still giving you what is effectively full access, in which case the test fail is the result of an inability to remove the default ACL from the directory. I suspect your build directory is owned by a different user than the one you're building with and/or has been moved or re-used from another Windows installation that has different SID.

Regards, Achim.

-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds
Previous: Adam DinwoodieNext: Adam Dinwoodie
Message 8 of 17 in “Is git-am expected to honor core.sharedRepository?”
  1. Matheus Tavares BernardinoDec 1, 2020
  2. Junio C HamanoDec 1, 2020
  3. apply: don't use core.sharedRepository to create working tree filesMatheus Tavares, Dec 1, 2020
  4. Junio C HamanoDec 2, 2020
  5. Adam DinwoodieDec 19, 2020
  6. Junio C HamanoDec 19, 2020
  7. Adam DinwoodieDec 19, 2020
  8. Achim GratzDec 19, 2020
  9. Adam DinwoodieDec 19, 2020
  10. Achim GratzDec 19, 2020
  11. Adam DinwoodieDec 22, 2020
  12. Matheus Tavares BernardinoDec 22, 2020
  13. t4129: fix setfacl-related permissions failureAdam Dinwoodie, Dec 23, 2020
  14. Matheus Tavares BernardinoJan 9, 2021
  15. Junio C HamanoJan 9, 2021
  16. Junio C HamanoDec 2, 2020
  17. Matheus Tavares BernardinoDec 3, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.