Re: [PATCH v3 2/2] http: fix the silent ignoring of proxy misconfiguraion

> On Tue, Apr 11, 2017 at 08:17:50PM +0300, Sergey Ryazanov wrote:
>> Earlier, the whole http.proxy option string was passed to curl without
>> any preprocessing so curl could complain about the invalid proxy
>> configuration.
>>
>> After the commit 372370f167 ("http: use credential API to handle proxy
>> authentication", 2016-01-26), if the user specified an invalid HTTP
>> proxy option in the configuration, then the option parsing is silently
>> fails and NULL will be passed to curl as a proxy. This forces curl to
>
> s/is silently/silently/
>
>> fall back to detecting the proxy configuration from the environment,
>> causing the http.proxy option ignoring.
>>
>> Fix this issue by checking the proxy option parsing result. If parsing
>> failed then print error message and die. Such behaviour allows user to
>> quickly figure the proxy misconfiguration and correct it.
>
> Two minor grammos:
>
> s/error/an error/;
> s/user/the user/;
>