Re: [PATCH v3 2/2] http: fix the silent ignoring of proxy misconfiguraion

From: Jeff King <peff@peff.net>
Date: Apr 11, 2017, 17:37 UTC
Message-ID: <20170411173722.asjrkpbbm4p6k6ov@sigill.intra.peff.net>
In-Reply-To: <20170411171750.18624-3-ryazanov.s.a@gmail.com>

On Tue, Apr 11, 2017 at 08:17:50PM +0300, Sergey Ryazanov wrote:

Show 8 quoted lines

> Earlier, the whole http.proxy option string was passed to curl without
> any preprocessing so curl could complain about the invalid proxy
> configuration.
> 
> After the commit 372370f167 ("http: use credential API to handle proxy
> authentication", 2016-01-26), if the user specified an invalid HTTP
> proxy option in the configuration, then the option parsing is silently
> fails and NULL will be passed to curl as a proxy. This forces curl to

s/is silently/silently/

Show 6 quoted lines

> fall back to detecting the proxy configuration from the environment,
> causing the http.proxy option ignoring.
> 
> Fix this issue by checking the proxy option parsing result. If parsing
> failed then print error message and die. Such behaviour allows user to
> quickly figure the proxy misconfiguration and correct it.

Two minor grammos:

s/error/an error/; s/user/the user/;

In the earlier discussion you mentioned a warning, but I like this die() much better.

Both patches look very clean, and nicely explained. Thanks for working on this.

-Peff