Re: [PATCH v2 resend] gitk: Use an external icon file on Windows

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Aug 9, 2012, 16:13 UTC
Message-ID: <CAHGBnuOwtkHMAUgY8r=9PiWT0MUH83FRQQ8eJuzRV43T5Oyduw@mail.gmail.com>
In-Reply-To: <7vmx24oybg.fsf@alter.siamese.dyndns.org>

On Thu, Aug 9, 2012 at 5:54 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

>>> Forwarding a misdirected patch to the maintainer who is free to pick
>>> or ignore.
>>
>> How am I supposed to know if a patch has been ignored as an oversight
>> (in which case I would resend), or because the maintainer decided not
>> to include it (in which case I would not resend in order to not annoy
>> the maintainer)?
>
> By hearing from Paul (or asking directly), perhaps?

I did that, in a private mail due to some temporary mailing list problems, but did not get an answer. So my question was referring to Paul. How I should know whether Paul ignores my patch due to an oversight, or because he is not interested? And because of this ambiguity in ignoring a patch I think an explicit NACK should be mandatory if a maintainer is not interested in a patch.

Show 5 quoted lines

> And that goes both ways.  If the logo of the "official" site is not
> something so important that git-scm.com can change without gaining
> community consensus first, then it equally is within the editorial
> discretion of individual git package's maintainer to keep using the
> original not the updated logo.

I admit that I was assuming community consensus on the new logo exactly *because* I saw it on git-scm.com. On the other hand, from my experience the Git community is not exactly one where is it particularly easy to get consensus on something, so I completely understand and support Scott's habit to sometimes go one way without consulting the community first.

Anyway, I'll include the patch into Git for Windows, because that's what our users ask for.

-- 
Sebastian Schuberth