git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 resend] gitk: Use an external icon file on Windows

From
Sebastian Schuberth <sschuberth@gmail.com>
Date
Aug 9, 2012, 06:54 UTC
Message-ID
<CAHGBnuOKsPJoRADfukCJ8abSVVKUy5vbuh18S7UD8rLScVq=GQ@mail.gmail.com>
In-Reply-To
<7v628trsry.fsf@alter.siamese.dyndns.org>
On Wed, Aug 8, 2012 at 11:13 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Forwarding a misdirected patch to the maintainer who is free to pick
> or ignore.

How am I supposed to know if a patch has been ignored as an oversight (in which case I would resend), or because the maintainer decided not to include it (in which case I would not resend in order to not annoy the maintainer)?

> Personally I am negative on it (nobody on the list asked for the
> "new" Git icon as far as I recall), but my voice on this counts just
> as little as others.

I guess most patches on the list come in unasked, so I cannot follow your negative attitude because of this. Also, the patch does not enforce the new icon on any platform. From a user's perspective, [1] as mentioned on [2] is the official Git homepage, thus the icon used on the homepage can be regarded as the official Git icon. In Git for Windows, we try to have a consistent user experience, and we had a report about gitk still using the "old" icon [3]. This patch fixes that, and I'm sending it upstream in an effort to not let msysgit's fork of git diverge too much from upstream.

[1] http://git-scm.com/ [2] http://en.wikipedia.org/wiki/Git_%28software%29#External_links [3] https://github.com/msysgit/msysgit/issues/44

-- 
Sebastian Schuberth
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 7 in “gitk: Use an external icon file on Windows”
  1. gitk: Use an external icon file on WindowsSebastian Schuberth, Jul 22, 2012
  2. gitk: Use an external icon file on WindowsSebastian Schuberth, Jul 23, 2012
  3. gitk: Use an external icon file on WindowsSebastian Schuberth, Aug 8, 2012
  4. Junio C HamanoAug 8, 2012
  5. Sebastian SchuberthAug 9, 2012
  6. Junio C HamanoAug 9, 2012
  7. Sebastian SchuberthAug 9, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.