git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] perl: regenerate perl.mak if perl -V changes

From
JWJeffrey Walton <noloader@gmail.com>
Date
Mar 29, 2017, 22:22 UTC
Message-ID
<CAH8yC8mkndAWP46M2L7TX8HF_y4xa5X29-Q--bA6Prurpya48Q@mail.gmail.com>
In-Reply-To
<CACBZZX70oXn7McjavzvK5S30EXjXQhLixhb=WYbKCKYXVo1KBA@mail.gmail.com>
Show 21 quoted lines
>>> Now the logic added in commit ee9be06770 ("perl: detect new files in
>>> MakeMaker builds", 2012-07-27) is extended to regenerate
>>> perl/perl.mak if there's any change to "perl -V".
>>
>> Nice. This fix is way simpler than I feared.
>>
>>> This will in some cases redundantly trigger perl/perl.mak to be
>>> re-made, e.g. if @INC is modified in ways the build process doesn't
>>> care about through sitecustomize.pl, but the common case is that we
>>> just do the right thing and re-generate perl/perl.mak when needed.
>>
>> I think that's fine. There's a related bug that the generation of
>> perl/perl.mak via recursive-make is sometimes racy. So that _might_
>> trigger more often as a result of this, but I think the solution is to
>> fix that race, not try to pretend it won't happen. :)
>
> We'll also redundantly trigger if you upgrade to a minor new perl
> version, but I think that's squarely in "who cares" territory. This'll
> only impact people working on git, and *occasionally* they might get a
> 100 ms hit when running make, as opposed to a cryptic error where
> they'll likely stare at it for a bit before running "make clean".

+1, I don't mind extra config or build times as long as things "just work" for the common case.

I was trying to figure out the use case that I was seeing. I was envisioning someone with Perl 4 in /usr/local who complained it would break some one-off setup. In the common case, the guy running Perl 4 should do the extra work, not the majority of users operating under the common case.

Jeff
Previous: Junio C Hamano
Message 10 of 10 in “Can't locate ExtUtils/MakeMaker.pm in @INC”
  1. Jeffrey WaltonMar 29, 2017
  2. Jeff KingMar 29, 2017
  3. perl: regenerate perl.mak if perl -V changesÆvar Arnfjörð Bjarmason, Mar 29, 2017
  4. perl: regenerate perl.mak if perl -V changesÆvar Arnfjörð Bjarmason, Mar 29, 2017
  5. stefan.naewe@atlas-elektronik.comMar 29, 2017
  6. perl: regenerate perl.mak if perl -V changesÆvar Arnfjörð Bjarmason, Mar 29, 2017
  7. Jeff KingMar 29, 2017
  8. Ævar Arnfjörð BjarmasonMar 29, 2017
  9. Junio C HamanoMar 29, 2017
  10. Jeffrey WaltonMar 29, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.