Re: [PATCH v3] perl: regenerate perl.mak if perl -V changes

From: Jeff King <peff@peff.net>
Date: Mar 29, 2017, 18:12 UTC
Message-ID: <20170329181228.n4t77pashdnirl3a@sigill.intra.peff.net>
In-Reply-To: <20170329135703.18860-1-avarab@gmail.com>

On Wed, Mar 29, 2017 at 01:57:03PM +0000, Ævar Arnfjörð Bjarmason wrote:

Show 6 quoted lines

> Change the perl/perl.mak build process so that the file is regenerated
> if the output of "perl -V" changes.
> 
> Before this change updating e.g. /usr/bin/perl to a new major version
> would cause the next "make" command to fail, since perl.mak has
> hardcoded paths to perl library paths retrieved from its first run.

This is one of those things that has been bugging me for years, but it comes up so rarely that I have never dug into it.

> Now the logic added in commit ee9be06770 ("perl: detect new files in
> MakeMaker builds", 2012-07-27) is extended to regenerate
> perl/perl.mak if there's any change to "perl -V".

Nice. This fix is way simpler than I feared.

> This will in some cases redundantly trigger perl/perl.mak to be
> re-made, e.g. if @INC is modified in ways the build process doesn't
> care about through sitecustomize.pl, but the common case is that we
> just do the right thing and re-generate perl/perl.mak when needed.

I think that's fine. There's a related bug that the generation of perl/perl.mak via recursive-make is sometimes racy. So that _might_ trigger more often as a result of this, but I think the solution is to fix that race, not try to pretend it won't happen. :)

-Peff