git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-mergetool: check return value from read

From
Andrew Ardill <andrew.ardill@gmail.com>
Date
Sep 20, 2011, 01:20 UTC
Message-ID
<CAH5451mt9mhRDQBYhUn=dO-SMyyhDNcv7nXfdsk-HKY3pMj77Q@mail.gmail.com>
In-Reply-To
<7vboug82qk.fsf@alter.siamese.dyndns.org>
On 20 September 2011 10:41, Junio C Hamano <gitster@pobox.com> wrote:
Show 18 quoted lines
> Jay Soffian <jaysoffian@gmail.com> writes:
>
>>> I suspect that it would be more consistent with 6b44577 (mergetool: check
>>> return value from read, 2011-07-01), which this patch is a follow-up to,
>>> to do:
>>>
>>>      read answer || return 1
>>>
>>> here.
>>
>> Thanks, sorry I missed that.
>
> Thank _you_ for spotting these unchecked "read"s.  Will queue.
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

I got hit by the ctrl+c bug while using mergetool just the other day. Thanks for the fix :)

Previous: Junio C Hamano
Message 5 of 5 in “git-mergetool--lib.sh: make check_unchanged return 1 on invalid read”
  1. git-mergetool--lib.sh: make check_unchanged return 1 on invalid readJay Soffian, Sep 19, 2011
  2. Junio C HamanoSep 19, 2011
  3. git-mergetool: check return value from readJay Soffian, Sep 19, 2011
  4. Junio C HamanoSep 20, 2011
  5. Andrew ArdillSep 20, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.