From: Andrew Ardill <andrew.ardill@gmail.com>
Date: Tue, 20 Sep 2011 01:20:22 GMT
Subject: Re: [PATCH] git-mergetool: check return value from read
Message-ID: <CAH5451mt9mhRDQBYhUn=dO-SMyyhDNcv7nXfdsk-HKY3pMj77Q@mail.gmail.com>
In-Reply-To: <7vboug82qk.fsf@alter.siamese.dyndns.org>

On 20 September 2011 10:41, Junio C Hamano <gitster@pobox.com> wrote:
> Jay Soffian <jaysoffian@gmail.com> writes:
>
>>> I suspect that it would be more consistent with 6b44577 (mergetool: check
>>> return value from read, 2011-07-01), which this patch is a follow-up to,
>>> to do:
>>>
>>>      read answer || return 1
>>>
>>> here.
>>
>> Thanks, sorry I missed that.
>
> Thank _you_ for spotting these unchecked "read"s.  Will queue.
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

I got hit by the ctrl+c bug while using mergetool just the other day.
Thanks for the fix :)