Re: [PATCH v4] git-svn: clarify the referent of dcommit's optional argument

From: Jon Seymour <jon.seymour@gmail.com>
Date: May 17, 2012, 01:46 UTC
Message-ID: <CAH3AnrpCJZt0acr7f5C5kwCF+KxgzD3dbeT+g7Ko5uCMxNqU0Q@mail.gmail.com>
In-Reply-To: <7vzk97bv2j.fsf@alter.siamese.dyndns.org>

On Thu, May 17, 2012 at 8:49 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 20 quoted lines

> Jon Seymour <jon.seymour@gmail.com> writes:
>
>>> +Originally, 'git svn' recommended that developers pulled or merged from
>>> +the 'git svn' branch.  This was because the author favored `git svn set-tree B`
>>> +to commit a single head rather than the `git svn set-tree A..B` notation to
>>> +commit multiple commits. Use of 'git pull' or 'git merge' with `git svn set-tree A...B`
>>
>> A...B -> A..B
>>
>> Will fix in next iteration, assuming Junio and Eric are otherwise
>> happy with the update.
>
> I don't have an opinion on the latter half of the patch that is primarily
> about the rationale given by "the author", i.e. Eric ;-), but the
> description of dcommit subcommand itself certainly looks simpler and more
> readble to me.
>
> Thanks.
>
>

Ok, I'll fix the ... issue mentioned above and (also some trailing whitespace) once Eric has given his feedback or acknowledgement.

jon.