git rev-list %an, %ae, %at bug in v1.7.10.1 and beyond

Hello all,

I believe I've found an issue in git v1.7.10.1 and v1.7.10.2 (and master) where the output of git rev-list has changed for some commits. Most commits do not appear to trigger the issue; it may be related to Unicode characters being used in the author name. I've run a git bisect and it appears the bug was introduced in 4b340cfab9c7a18e39bc531d6a6ffaffdf95f62d.

Built from master (as well as using the 1.7.10.1 and 1.7.10.2 release tags), I get output like this: ================================ Output ===================================== aphrael:qa-resources.git bturner$ git rev-list --format="%H|%h|%P|%p|%an|%ae|%at%n%B%n@@object_end@@" -1 5c1ccdec5f84aa149a4978f729fdda70769f942f commit 5c1ccdec5f84aa149a4978f729fdda70769f942f 5c1ccdec5f84aa149a4978f729fdda70769f942f|5c1ccde|02c78bc39ac6192623bf080e3e2ac892a4f5764c|02c78bc||| commit with unicode name

@@object_end@@ ================================ End ========================================

Note that the author name, e-mail and timestamp values are all missing (the three |'s in a row at the end).

Built from 0dbe6592ccbd1a394a69a52074e3729d546fe952, the parent of 4b340cf, and in previous versions of git (1.7.10 and earlier), I got output like this: ================================ Output ===================================== aphrael:qa-resources.git bturner$ git rev-list --format="%H|%h|%P|%p|%an|%ae|%at%n%B%n@@object_end@@" -1 5c1ccdec5f84aa149a4978f729fdda70769f942f commit 5c1ccdec5f84aa149a4978f729fdda70769f942f 5c1ccdec5f84aa149a4978f729fdda70769f942f|5c1ccde|02c78bc39ac6192623bf080e3e2ac892a4f5764c|02c78bc|a|farmas@atlassian.com|1327876222 commit with unicode name

@@object_end@@ ================================ End ========================================

Note that the author name, e-mail and timestamp are all present. The "a" appears as ASCII here, but it's actually a UTF-16LE character (the terminal on the Mac is being "helpful").

To try and verify whether the difference is a bug or a bugfix (because I wasn't certain whether perhaps the output from earlier versions was the result of a bug which was fixed in 1.7.10.1 and on), I compared the git rev-list output with git cat-file -p (again, built from master): ================================ Output ===================================== aphrael:qa-resources.git bturner$ git cat-file -p 5c1ccdec5f84aa149a4978f729fdda70769f942f tree dd173cb70baaac07bdf405f4e3db110e7fafd180 parent 02c78bc39ac6192623bf080e3e2ac892a4f5764c author a <farmas@atlassian.com> 1327876222 +1100 committer a <farmas@atlassian.com> 1327876222 +1100

commit with unicode name ================================ End ========================================

The git cat-file output is consistent across versions of git where I'm seeing the rev-list issue and versions where I'm not.

I would be happy to provide a zip file containing the repository with the commit shown in all the output above, if that will facilitate testing/fixing the issue. Just let me know where to put it. I lack the C chops to provide a patch myself; sorry about that.

Best regards, Bryan Turner