git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git rev-list %an, %ae, %at bug in v1.7.10.1 and beyond

From
Jeff King <peff@peff.net>
Date
May 22, 2012, 04:35 UTC
Message-ID
<20120522043509.GB6859@sigill.intra.peff.net>
In-Reply-To
<20120522043221.GA6859@sigill.intra.peff.net>
On Tue, May 22, 2012 at 12:32:21AM -0400, Jeff King wrote:
Show 7 quoted lines
> I'm not too surprised this is broken (in fact, I'm surprised it ever
> really worked). UTF-16, especially representing pure ascii characters,
> will have embedded NULs. Most of the code assumes that things like names
> and emails are NUL-terminated and ascii-compatible (so ascii, or some
> ascii-superset encoding like utf8, iso8859-1, etc). You can store a
> commit message (and name) in utf-16 if you tell git that you are doing
> so, but we should be re-encoding it before handling it.

Actually, I take that back. I think storing in utf-16 would probably fail. We need to use ascii to even read the headers to get to the encoding header to realize that it is in utf-16. So I believe we really do only support ascii-superset encodings.

-Peff
Previous: Jeff KingNext: Bryan Turner
Message 3 of 6 in “git rev-list %an, %ae, %at bug in v1.7.10.1 and beyond”
  1. Bryan TurnerMay 21, 2012
  2. Jeff KingMay 22, 2012
  3. Jeff KingMay 22, 2012
  4. Bryan TurnerMay 22, 2012
  5. Jeff KingMay 22, 2012
  6. Jeff KingMay 22, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.