Re: [PATCH v4] git-gui: add hotkey to toggle "Amend Last Commit"

From: Birger Skogeng Pedersen <birger.sp@gmail.com>
Date: Sep 13, 2019, 21:32 UTC
Message-ID: <CAGr--=JhBYmYCJNNm8DyL+MKU0V0V-cwzH4WABX-dvE+uXNwDw@mail.gmail.com>
In-Reply-To: <20190913211152.8860-1-birger.sp@gmail.com>

On Fri, Sep 13, 2019 at 4:37 PM Pratyush Yadav <me@yadavpratyush.com> wrote:

Show 7 quoted lines

> Hi Birger,
>
> I'm afraid you are working on an older version of this patch. You should
> be re-rolling [0], which works well with Bert's "amend check button"
> change.
>
> [0] https://public-inbox.org/git/b82a00441ff1a6a9cea3fd235c1c33729ec31b71.1567713659.git.bert.wesarg@googlemail.com/

Forgive me, I get a little bit confused. Should my patch be based on "next" or "master" branch? Also, is it an issue that this patch won't work unless you merge Bert's 1/2 patch[0]? Your feedback cannot be too specific, I want to learn how to do this properly :-)

[0] https://public-inbox.org/git/ab1f68cc8552e405c9d04622be1e728ab81bda17.1567713659.git.bert.wesarg@googlemail.com/

Birger