Re: [PATCH 2/2] git-gui: add hotkey to toggle "Amend Last Commit" check button/menu

From: Philip Oakley <philipoakley@iee.email>
Date: Sep 12, 2019, 22:23 UTC
Message-ID: <56a6fbf8-4486-6bad-f847-793bb6b4e070@iee.email>
In-Reply-To: <db01db41-eff0-fb56-161a-ba26d1b18f55@xiplink.com>

On 12/09/2019 22:34, Marc Branchaud wrote:

Show 15 quoted lines

>>> I just tested what happens when you press Ctrl+e while Caps Lock is
>>> enabled; the Ctrl+e binding is not invoked. That's probably why other
>>> key bindings have the same function bound for both lower- and
>>> upper-case letters, to have the same behaviour with/without Caps Lock
>>> enabled. With that in mind, we should probably bind Ctrl+E aswell.
>>
>> Nice catch! Makes sense to have the same behaviour for both caps lock
>> enabled and disabled.
>
> (I've been a git-gui user for many years...)
>
> I disagree!  Who expects anything to work properly when capslock is on?
>
>         M.
>

I'd tend to agree. In other areas the use of shift is often used as the complement of the unshifted action, so it does feel 'odd'. Thus it could be used directly as the bool for amend or direct commit.

This all assumes that Caps Lock is equivalent to having the shift on, rather than being a special extra key.

Philip