git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH][GSoC] parse-options: Add OPT_SET_INT_NONEG.

From
Yuxuan Shui <yshuiv7@gmail.com>
Date
Mar 12, 2014, 18:33 UTC
Message-ID
<CAGqt0zyPOGY18EhWPMTGdtU54NDYS0ppRHhemhDArX7oE-0LGw@mail.gmail.com>
In-Reply-To
<xmqqr467mfrg.fsf@gitster.dls.corp.google.com>
Hi,
On Thu, Mar 13, 2014 at 2:30 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 17 quoted lines
> Duy Nguyen <pclouds@gmail.com> writes:
>
>> By convention, no full stop in the subject line. The subject should
>> summarize your changes and "add ..NONEG" is just one part of it. The
>> other is "convert to use ...NONEG". So I suggest "parse-options:
>> convert to use new macro OPT_SET_INT_NONEG()" or something like that.
>>
>> You should also explain in the message body (before Signed-off-by:)
>> why this is a good thing to do. My guess is better readability and
>> harder to make mistakes in the future when you have to declare new
>> options with noneg.
>
> As I said elsewhere, I am not sure if doubling the number of
> OPT_<type> macros as your micro suggestion proposes is the right
> solution to the problem.
>
> What are we trying to solve?
OK, I'll switch to another micro project.
-- 
Regards
Yuxuan Shui
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 6 in “[GSoC] parse-options: Add OPT_SET_INT_NONEG.”
  1. [GSoC] parse-options: Add OPT_SET_INT_NONEG.Yuxuan Shui, Mar 11, 2014
  2. Duy NguyenMar 12, 2014
  3. Yuxuan ShuiMar 12, 2014
  4. Junio C HamanoMar 12, 2014
  5. Yuxuan ShuiMar 12, 2014
  6. Junio C HamanoMar 12, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.