Re: [PATCH v2 6/6] commit-graph: add repo arg to graph readers
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- Jul 10, 2018, 17:23 UTC
- Message-ID
- <CAGf8dgK3bWgAEE6Fuck=BHUG47V0kXi-Ph_gJnhk0mz2_84h3g@mail.gmail.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.1807101517290.75@tvgsbejvaqbjf.bet>
On Tue, Jul 10, 2018 at 6:18 AM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 13 quoted lines
>> 32-bit builds complain about this:
>>
>> t/helper/test-repository.c: In function 'test_parse_commit_in_graph':
>> t/helper/test-repository.c:28:9: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'timestamp_t {aka long long unsigned int}' [-Werror=format=]
>> printf("%lu", c->date);
>> ^
>> cc1: all warnings being treated as errors
>> Makefile:2262: recipe for target 't/helper/test-repository.o' failed
>> make: *** [t/helper/test-repository.o] Error 1
>
> Let's also state how we usually fix this:
>
> printf("%"PRItime, c->date);Thanks for noticing this - I'll do this if a reroll is needed.