git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] dir-iterator: drop unused `DIR_ITERATOR_FOLLOW_SYMLINKS`

From
Matheus Tavares Bernardino <matheus.tavb@gmail.com>
Date
Feb 17, 2023, 00:16 UTC
Message-ID
<CAGdrTFhHBU2BNYdYr7LbOS7i1LOHGjWLw_d5ZJAXxvTKyLiFCA@mail.gmail.com>
In-Reply-To
<Y+6Mcnng0u6sz+C6@nand.local>
Hi, Taylor and Jeff
On Thu, Feb 16, 2023 at 5:05 PM Taylor Blau <me@ttaylorr.com> wrote:
Show 5 quoted lines
>
> On Thu, Feb 16, 2023 at 03:03:01PM -0500, Taylor Blau wrote:
> > I have no idea either. From a cursory scan, I think I'd err on the side
> > of it being vestigial. But Matheus (cc'd) should be able to tell us for
> > sure.

Oh, it's been some time. But yes, dir5 is vestigial and should indeed be removed. It was created back when I wanted to make dir-iterator detect and avoid recursive symlinks (see this [1] earlier version of the patch, where there was a test grepping for dir5 at the output). But this idea ended up being discarded and I must have forgotten to remove the dir5.

[1]: https://lore.kernel.org/git/20190502144829.4394-7-matheus.bernardino@usp.br/
Previous: Taylor BlauNext: Jeff King
Message 5 of 6 in “dir-iterator: drop unused `DIR_ITERATOR_FOLLOW_SYMLINKS`”
  1. dir-iterator: drop unused `DIR_ITERATOR_FOLLOW_SYMLINKS`Taylor Blau, Feb 16, 2023
  2. Jeff KingFeb 16, 2023
  3. Taylor BlauFeb 16, 2023
  4. Taylor BlauFeb 16, 2023
  5. Matheus Tavares BernardinoFeb 17, 2023
  6. 2/1 t0066: drop setup of "dir5"Jeff King, Feb 17, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.