From: Matheus Tavares Bernardino <matheus.tavb@gmail.com>
Date: Fri, 17 Feb 2023 00:16:50 GMT
Subject: Re: [PATCH] dir-iterator: drop unused `DIR_ITERATOR_FOLLOW_SYMLINKS`
Message-ID: <CAGdrTFhHBU2BNYdYr7LbOS7i1LOHGjWLw_d5ZJAXxvTKyLiFCA@mail.gmail.com>
In-Reply-To: <Y+6Mcnng0u6sz+C6@nand.local>

Hi, Taylor and Jeff

On Thu, Feb 16, 2023 at 5:05 PM Taylor Blau <me@ttaylorr.com> wrote:
>
> On Thu, Feb 16, 2023 at 03:03:01PM -0500, Taylor Blau wrote:
> > I have no idea either. From a cursory scan, I think I'd err on the side
> > of it being vestigial. But Matheus (cc'd) should be able to tell us for
> > sure.

Oh, it's been some time. But yes, dir5 is vestigial and should indeed
be removed. It was created back when I wanted to make dir-iterator
detect and avoid recursive symlinks (see this [1] earlier version of
the patch, where there was a test grepping for dir5 at the output).
But this idea ended up being discarded and I must have forgotten to
remove the dir5.

[1]: https://lore.kernel.org/git/20190502144829.4394-7-matheus.bernardino@usp.br/