git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] fast-import: don't allow to note on empty branch

From
Sverre Rabbelier <srabbelier@gmail.com>
Date
Sep 22, 2011, 22:29 UTC
Message-ID
<CAGdFq_jDvWveWm5cOXA9QQC+PmaEvwmEs7PmjoACmQXxkdT62g@mail.gmail.com>
In-Reply-To
<1316720825-32552-3-git-send-email-divanorama@gmail.com>
Heya,
On Thu, Sep 22, 2011 at 21:47, Dmitry Ivankov <divanorama@gmail.com> wrote:
Show 9 quoted lines
> 'reset' command makes fast-import start a branch from scratch. It's name
> is kept in lookup table but it's sha1 is null_sha1 (special value).
> 'notemodify' command can be used to add a note on branch head given it's
> name. lookup_branch() is used it that case and it doesn't check for
> null_sha1. So fast-import writes a note for null_sha1 object instead of
> giving a error.
>
> Add a check to deny adding a note on empty branch and add a corresponding
> test.
Makes sense as well.
-- 
Cheers,

Sverre Rabbelier
Previous: Dmitry Ivankov
Message 5 of 5 in “fast-import: empty/reset branch bugs”
  1. 0/2 fast-import: empty/reset branch bugsDmitry Ivankov, Sep 22, 2011
  2. 1/2 fast-import: don't allow to tag empty branchDmitry Ivankov, Sep 22, 2011
  3. Sverre RabbelierSep 22, 2011
  4. 2/2 fast-import: don't allow to note on empty branchDmitry Ivankov, Sep 22, 2011
  5. Sverre RabbelierSep 22, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.