From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Thu, 22 Sep 2011 22:29:24 GMT
Subject: Re: [PATCH 2/2] fast-import: don't allow to note on empty branch
Message-ID: <CAGdFq_jDvWveWm5cOXA9QQC+PmaEvwmEs7PmjoACmQXxkdT62g@mail.gmail.com>
In-Reply-To: <1316720825-32552-3-git-send-email-divanorama@gmail.com>

Heya,

On Thu, Sep 22, 2011 at 21:47, Dmitry Ivankov <divanorama@gmail.com> wrote:
> 'reset' command makes fast-import start a branch from scratch. It's name
> is kept in lookup table but it's sha1 is null_sha1 (special value).
> 'notemodify' command can be used to add a note on branch head given it's
> name. lookup_branch() is used it that case and it doesn't check for
> null_sha1. So fast-import writes a note for null_sha1 object instead of
> giving a error.
>
> Add a check to deny adding a note on empty branch and add a corresponding
> test.

Makes sense as well.

-- 
Cheers,

Sverre Rabbelier