Re: [PATCH] pull: introduce a pull.rebase option to enable --rebase
- From
Sverre Rabbelier <srabbelier@gmail.com>
- Date
- Nov 6, 2011, 09:23 UTC
- Message-ID
- <CAGdFq_hpp=NTJxYM=MNQOyGz73cRcxxWpYw93agDNgP72NAduA@mail.gmail.com>
- In-Reply-To
- <7v8vnt7kvd.fsf@alter.siamese.dyndns.org>
Heya,
On Sun, Nov 6, 2011 at 08:47, Junio C Hamano <gitster@pobox.com> wrote:
> I see many reviewed-by lines, but what kind of review did this patch have, > exactly? It seem to break its own test (branch.to-rebase.rebase should > override pull.rebase).
We looked at the patch the same way one would on list, and I assumed that the tests passed. Ævar, did you sent a wrong version by accident perhaps?
> Thanks for other topics from the Amsterdam together, by the way. I did not > comment on them individually but they looked mostly reasonable from a > quick glance.
Thanks.
-- Cheers, Sverre Rabbelier