From: Sverre Rabbelier Date: Sun, 06 Nov 2011 09:23:28 GMT Subject: Re: [PATCH] pull: introduce a pull.rebase option to enable --rebase Message-ID: In-Reply-To: <7v8vnt7kvd.fsf@alter.siamese.dyndns.org> Heya, On Sun, Nov 6, 2011 at 08:47, Junio C Hamano wrote: > I see many reviewed-by lines, but what kind of review did this patch have, > exactly? It seem to break its own test (branch.to-rebase.rebase should > override pull.rebase). We looked at the patch the same way one would on list, and I assumed that the tests passed. Ævar, did you sent a wrong version by accident perhaps? > Thanks for other topics from the Amsterdam together, by the way. I did not > comment on them individually but they looked mostly reasonable from a > quick glance. Thanks. -- Cheers, Sverre Rabbelier