Re: [PATCH 2/4] receive-pack: implement advertising and receiving push options

From: Stefan Beller <sbeller@google.com>
Date: Jul 8, 2016, 22:43 UTC
Message-ID: <CAGZ79kbj8tGb9BsTo_CGqOdfsinJrafHAY5HhQEQDCtAXQqKgw@mail.gmail.com>
In-Reply-To: <20160708223533.GA11056@sigill.intra.peff.net>

On Fri, Jul 8, 2016 at 3:35 PM, Jeff King <peff@peff.net> wrote:

Show 7 quoted lines

>
> Yes. I haven't been following the intermediate discussion and patches,
> but I don't see anything wrong with the general design above. I think
> you do need to use rp_error() to get the die message to the client for
> non-ssh cases, though (that is a problem with other protocol-error
> messages, too; I wonder if we should install a custom die handler, or
> convert them all to some kind of rp_die()).

Some of the rp_error messages do not want to die(), but most seem to be ok when the rp_error would die.

I'll look into that.

>
> -Peff