git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/5] unpack-trees: factor file removal out of check_updates

From
Stefan Beller <sbeller@google.com>
Date
Jan 9, 2017, 19:30 UTC
Message-ID
<CAGZ79kbZz5s5TdudGcOADDxYShTAm5sTCHRo81SSCc13MoF7WA@mail.gmail.com>
In-Reply-To
<20170107013602.act7aouuzgzpwb54@sigill.intra.peff.net>
On Fri, Jan 6, 2017 at 5:36 PM, Jeff King <peff@peff.net> wrote:
>> +static int remove_workingtree_files(struct unpack_trees_options *o,
>> +     unsigned cnt = 0;
>
> "cnt" is unsigned here, as it is in the caller. Should the return value
> match?
Yes, obviously. :/

Thanks for catching, Stefan

Previous: Jeff KingNext: Stefan Beller
Message 7 of 9 in “Re: [PATCHv2] unpack-trees: move checkout state into check_updates”
  1. Stefan BellerJan 6, 2017
  2. 0/5 refactor unpack-treesStefan Beller, Jan 6, 2017
  3. 1/5 unpack-trees: move checkout state into check_updatesStefan Beller, Jan 6, 2017
  4. 5/5 unpack-trees: factor working tree update out of check_updatesStefan Beller, Jan 6, 2017
  5. 4/5 unpack-trees: factor file removal out of check_updatesStefan Beller, Jan 6, 2017
  6. Jeff KingJan 7, 2017
  7. Stefan BellerJan 9, 2017
  8. 3/5 unpack-trees: factor progress setup out of check_updatesStefan Beller, Jan 6, 2017
  9. 2/5 unpack-trees: remove unneeded continueStefan Beller, Jan 6, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.