Re: [PATCHv2] unpack-trees: move checkout state into check_updates

From: Stefan Beller <sbeller@google.com>
Date: Jan 6, 2017, 21:03 UTC
Message-ID: <CAGZ79kaM=Uosm7KAvAP-8w59Tyfc7LZiV3ZOr=PZnBgMCzr2AA@mail.gmail.com>
In-Reply-To: <xmqq8tqv6051.fsf@gitster.mtv.corp.google.com>

On Sat, Dec 31, 2016 at 5:26 PM, Junio C Hamano <gitster@pobox.com> wrote:

>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
>
> I'd add René's Reviewed-by: here.

done

Show 7 quoted lines

>
> I think moving heavier and initialized variables earlier and more
> lightweight and ephemeral ones like "i" later does make it easier to
> follow.  "errs" has the significance and the lifetime similar to
> cnt/total, and logically should be higher, though.  It is not a big
> enough deal to reroll (but as your futzing of the variable definition
> order was not a big enough deal to do in this patch, either, so...).

I will send out a series, that is based on this patch shortly; as I fuzzed again with the small variables, that series doesn't apply on this version but the version to be sent out shortly.

>
> Queued.  Thanks.

please replace with the following series.