Re: sb/more-repo-in-api, was Re: What's cooking in git.git (Jan 2019, #01; Mon, 7)

From: Stefan Beller <sbeller@google.com>
Date: Jan 9, 2019, 21:28 UTC
Message-ID: <CAGZ79kbSxBde16v7J-Px=fYJZ=qdpUVP-W75mdAYt=-rEbR2Tw@mail.gmail.com>
In-Reply-To: <xmqqr2dm4yth.fsf@gitster-ct.c.googlers.com>

On Tue, Jan 8, 2019 at 1:36 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

>
> Jonathan Tan <jonathantanmy@google.com> writes:
>
> >>  The in-core repository instances are passed through more codepaths.
> >
> > I think this is ready to be considered for merging to next. This series looks
> > good both to Stolee [1] and to me (I replied to a previous version with
> > comments on patch 18 [2] which Stefan has addressed, as can be seen in the
> > inter-diff provided by Junio [3] - I probably should have replied to the latest
> > version stating this too).
>
> Alright, thanks.
>
> While attempting to resolve conflicts with this and Peff's "get rid
> of has_sha1_file()" topic, I found it somewhat disturbing that
> sha1-file.c still was a mixture of functions that do and do not take
> the repository pointer,

I agree that the current state is less than optimal, but that comes down to the workflow? Most of the later series regarding the repo refactoring are crafting some minimal set of changes that make sense to reach one specific goal. It would have been easier if we could have refactored the whole code base at once.

> but perhaps it's something we need to polish
> over time on top.

Yeah, that is my current take. And best we'd have more patches as "t/helper/test-repository: celebrate independence from the_repository" to make sure we don't have bugs creeping into the code base.

Thanks, Stefan