Re: [PATCH 3/5] match-trees: use hashcpy to splice trees

From: Jeff King <peff@peff.net>
Date: Jan 14, 2019, 15:40 UTC
Message-ID: <20190114154019.GA4202@sigill.intra.peff.net>
In-Reply-To: <20190114013017.GP423984@genre.crustytoothpaste.net>

On Mon, Jan 14, 2019 at 01:30:17AM +0000, brian m. carlson wrote:

Show 10 quoted lines

> > > So the "most correct" thing is probably something like this:
> > 
> > Of course, it would be nice if what I sent compiled. ;)
> > 
> > rewrite_here does double duty: it's the pointer in the tree that we need
> > to rewrite, and it's also the oid we pass down recursively. So we have
> > to handle both cases, like so:
> 
> Since I took most of the patch you wrote, may I apply your sign-off to
> the resulting patch I send out?

Yes, definitely.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.