Re: [PATCH] attr: add counted string version of git_attr()

From: Stefan Beller <sbeller@google.com>
Date: May 18, 2016, 21:36 UTC
Message-ID: <CAGZ79kbMsitKNeb-D3gmTFwrRS-6ZiCZcmu1MP42UCd5AHcHbA@mail.gmail.com>
In-Reply-To: <xmqqmvnnqdtd.fsf_-_@gitster.mtv.corp.google.com>

On Wed, May 18, 2016 at 2:03 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> Often a potential caller has <name, namelen> pair that
> represents the name it wants to create an attribute out of.
>
> When name[namelen] is not NUL, the caller has to xmemdupz()
> only to call git_attr().
>
> Add git_attr_counted() that takes such a counted string instead of
> "const char *name".

s/ "const char *name"/a standard C string that is null terminated/ maybe?

"const char *name" is not a strong hint that it is not counted?