Re: [PATCHv7 5/5] pathspec: allow querying for attributes

From: Stefan Beller <sbeller@google.com>
Date: May 18, 2016, 19:42 UTC
Message-ID: <CAGZ79kaMU=H7x7Gxfk39No42kxNdrqykMyx+uD7gjDsK087m1g@mail.gmail.com>
In-Reply-To: <20160518190222.28105-6-sbeller@google.com>

On Wed, May 18, 2016 at 12:02 PM, Stefan Beller <sbeller@google.com> wrote:

Show 8 quoted lines

>  void free_pathspec(struct pathspec *pathspec)
>  {
> +       int i, j;
> +       for (i = 0; i < pathspec->nr; i++) {
> +               for (j = 0; j < pathspec->items[j].attr_match_nr; j++)
> +                       free(pathspec->items[i].attr_match[j].value);
> +               free(pathspec->items[i].attr_match);
> +               git_attr_check_free(pathspec->items[i].attr_check);

This is faulty as may be NULL and git_attr_check_free assumes its argument is not NULL. So I'll add a guard here in a reoll.