Re: [PATCH] submodule--helper: fix 'dubious bitfield' sparse warnings

From: Stefan Beller <sbeller@google.com>
Date: Feb 25, 2016, 20:28 UTC
Message-ID: <CAGZ79kb5YGyeEeW0LyA=1nX9+XkUPwxsFp6xQqRekvb9W2M2pA@mail.gmail.com>
In-Reply-To: <56CF5908.7090800@ramsayjones.plus.com>

On Thu, Feb 25, 2016 at 11:42 AM, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

Show 11 quoted lines

>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Stefan,
>
> If you need to re-roll (err, one of your) 'sb/submodule-parallel-update'
> branches, could you please squash this into the relevant patch.
> (ie. "git submodule update: have a dedicated helper for cloning", 23-02-2016).
>
> Thanks!

It's part of v17 already.

Thanks, Stefan

Show 35 quoted lines

>
> ATB,
> Ramsay Jones
>
>  builtin/submodule--helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index f8cdce9..482a3cc 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -563,7 +563,7 @@ struct submodule_update_clone {
>         /* index into 'list', the list of submodules to look into for cloning */
>         int current;
>         struct module_list list;
> -       int warn_if_uninitialized : 1;
> +       unsigned int warn_if_uninitialized : 1;
>         /* update parameter passed via commandline*/
>         struct submodule_update_strategy update;
>         /* configuration parameters which are passed on to the children */
> @@ -575,7 +575,7 @@ struct submodule_update_clone {
>         /* lines to be output */
>         struct string_list projectlines;
>         /* If we want to stop as fast as possible and return an error */
> -       int quickstop : 1;
> +       unsigned int quickstop : 1;
>  };
>  #define SUBMODULE_UPDATE_CLONE_INIT {0, MODULE_LIST_INIT, 0, \
>         SUBMODULE_UPDATE_STRATEGY_INIT, 0, NULL, NULL, NULL, NULL, \
> --
> 2.7.0
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html