git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] submodule--helper: fix 'dubious bitfield' sparse warnings

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Feb 25, 2016, 19:42 UTC
Message-ID
<56CF5908.7090800@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Stefan,

If you need to re-roll (err, one of your) 'sb/submodule-parallel-update' branches, could you please squash this into the relevant patch. (ie. "git submodule update: have a dedicated helper for cloning", 23-02-2016).

Thanks!

ATB, Ramsay Jones

 builtin/submodule--helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index f8cdce9..482a3cc 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -563,7 +563,7 @@ struct submodule_update_clone {
 	/* index into 'list', the list of submodules to look into for cloning */
 	int current;
 	struct module_list list;
-	int warn_if_uninitialized : 1;
+	unsigned int warn_if_uninitialized : 1;
 	/* update parameter passed via commandline*/
 	struct submodule_update_strategy update;
 	/* configuration parameters which are passed on to the children */
@@ -575,7 +575,7 @@ struct submodule_update_clone {
 	/* lines to be output */
 	struct string_list projectlines;
 	/* If we want to stop as fast as possible and return an error */
-	int quickstop : 1;
+	unsigned int quickstop : 1;
 };
 #define SUBMODULE_UPDATE_CLONE_INIT {0, MODULE_LIST_INIT, 0, \
 	SUBMODULE_UPDATE_STRATEGY_INIT, 0, NULL, NULL, NULL, NULL, \
-- 
2.7.0
Next: Stefan Beller
Message 1 of 2 in “submodule--helper: fix 'dubious bitfield' sparse warnings”
  1. submodule--helper: fix 'dubious bitfield' sparse warningsRamsay Jones, Feb 25, 2016
  2. Stefan BellerFeb 25, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.