Re: [PATCH 5/6] submodule: fixup nested submodules after moving the submodule

From: Stefan Beller <sbeller@google.com>
Date: Mar 28, 2018, 19:08 UTC
Message-ID: <CAGZ79kb1z8Ro9XV72s0-8O_D68VbLWbA=KT2EPOvgfi+e2YWCg@mail.gmail.com>
In-Reply-To: <20180328173543.GA159395@google.com>

Show 6 quoted lines

>> +     if (repo_init(&subrepo, sub_gitdir, sub_worktree))
>> +             return;
>
> Note that in Duy's object-store series he made this function private
> (IIRC) so this will result in some clash of the two series.
>

Yes, that is the case. I wonder if I'd rather revert to v1 where we only use the submodule repo init, or if we revert b2f0eceecf (repository: initialize the_repository in main(), 2018-03-03) partially to have repo_init available.

I would think the approach with submodule init is a bit cleaner though has some more lines of code, using just repo_init seems easier, but we really have no use case for a separate repo_init unless they are submodules. And here we ought to check for the repo being a submodule.

Not yet sure which path to take.