Re: [PATCH 3/5] submodule-config: add repository argument to submodule_from_{name, path}
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- Mar 27, 2018, 23:04 UTC
- Message-ID
- <20180327160443.5034f7db908c08fe3c301ab9@google.com>
- In-Reply-To
- <20180327213918.77851-4-sbeller@google.com>
On Tue, 27 Mar 2018 14:39:16 -0700 Stefan Beller <sbeller@google.com> wrote:
Show 6 quoted lines
> -extern const struct submodule *submodule_from_name( > +extern const struct submodule *submodule_from_name(struct repository *r, > const struct object_id *commit_or_tree, const char *name); > -extern const struct submodule *submodule_from_path( > +extern const struct submodule *submodule_from_path(struct repository *r, > const struct object_id *commit_or_tree, const char *path);
There is a recent change to CodingGuidelines that states to not include "extern" in 89a9f2c862 ("CodingGuidelines: mention "static" and "extern"", 2018-02-08), so consider removing "extern" since you're already changing this file.
Other than that,
Reviewed-by: Jonathan Tan <jonathantanmy@google.com>