git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] submodule.c: warn about missing submodule git directories

From
Stefan Beller <sbeller@google.com>
Date
Aug 29, 2018, 20:32 UTC
Message-ID
<CAGZ79kaq2oBBfFExCTKoNMhTx7iKRto0zddPknWn5qRjw0fKkw@mail.gmail.com>
In-Reply-To
<xmqq1sahcctx.fsf@gitster-ct.c.googlers.com>
On Wed, Aug 29, 2018 at 10:17 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 16 quoted lines
>
> Stefan Beller <sbeller@google.com> writes:
>
> > Not quite, as this is ...
> >
> > Looking at the test in the previous patch, I would think a reasonable workflow
> > in the test is ...
> >
> >> The MOVE_HEAD_FORCE codepath that follows this hunk is, eh, already
> >> forcing to correct the situation, so there is no need to touch that,
> >> which makes sense, if I understand correctly.
> >
> > No, that is not executed for now as it depends on 'old_head'.
>
> All explanation worth having in the log message to help future
> readers, don't you think?
ok, will do.

Thanks, Stefan

Previous: Junio C HamanoNext: Jonathan Nieder
Message 6 of 10 in “t2013: add test for missing but active submodule”
  1. 1/2 t2013: add test for missing but active submoduleStefan Beller, Aug 27, 2018
  2. 2/2 submodule.c: warn about missing submodule git directoriesStefan Beller, Aug 27, 2018
  3. Junio C HamanoAug 28, 2018
  4. Stefan BellerAug 28, 2018
  5. Junio C HamanoAug 29, 2018
  6. Stefan BellerAug 29, 2018
  7. Jonathan NiederSep 5, 2018
  8. Stefan BellerSep 7, 2018
  9. Jonathan NiederSep 7, 2018
  10. SZEDER GáborAug 29, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.