Re: [PATCH 2/2] submodule.c: warn about missing submodule git directories

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 5, 2018, 19:18 UTC
Message-ID: <20180905191849.GB120842@aiede.svl.corp.google.com>
In-Reply-To: <20180827221257.149257-2-sbeller@google.com>

Hi,

Stefan Beller wrote:

Show 10 quoted lines

> This is the continuation of f2d48994dc1 (submodule.c: submodule_move_head
> works with broken submodules, 2017-04-18), which tones down the case of
> "broken submodule" in case of a missing git directory of the submodule to
> be only a warning.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  submodule.c                   | 16 ++++++++++++++++
>  t/t2013-checkout-submodule.sh |  2 +-
>  2 files changed, 17 insertions(+), 1 deletion(-)

I don't understand what workflow this is a part of.

If the submodule is missing, shouldn't we make it non-missing instead of producing a partial checkout that doesn't build?

Thanks, Jonathan