git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] attr.c: simplify macroexpand_one()

From
Stefan Beller <sbeller@google.com>
Date
May 16, 2016, 16:13 UTC
Message-ID
<CAGZ79kanUufPKHK3-QGoTK8jju_iRGokpXpR4-7Zwc+tAodC4A@mail.gmail.com>
In-Reply-To
<CAPc5daVH_qveYBnxybvZYTuVKNBhG7PnJxeY9f8zVXqNxpvzVQ@mail.gmail.com>
On Sun, May 15, 2016 at 9:41 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> On Sun, May 15, 2016 at 8:31 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> On Sun, May 15, 2016 at 6:57 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>> The double-loop wants to do an early return immediately when one
>>> matching macro is found.  Eliminate the extra variable 'a' used for
>>> that purpose and rewrite the "assign found itme to 'a' to make it
>>
>> What's "itme"?
>
> item.
The code looks good.

Thanks, Stefan

Previous: Junio C Hamano
Message 4 of 4 in “attr.c: simplify macroexpand_one()”
  1. attr.c: simplify macroexpand_one()Junio C Hamano, May 15, 2016
  2. Eric SunshineMay 16, 2016
  3. Junio C HamanoMay 16, 2016
  4. Stefan BellerMay 16, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.