From: Stefan Beller <sbeller@google.com>
Date: Mon, 16 May 2016 16:13:09 GMT
Subject: Re: [PATCH] attr.c: simplify macroexpand_one()
Message-ID: <CAGZ79kanUufPKHK3-QGoTK8jju_iRGokpXpR4-7Zwc+tAodC4A@mail.gmail.com>
In-Reply-To: <CAPc5daVH_qveYBnxybvZYTuVKNBhG7PnJxeY9f8zVXqNxpvzVQ@mail.gmail.com>

On Sun, May 15, 2016 at 9:41 PM, Junio C Hamano <gitster@pobox.com> wrote:
> On Sun, May 15, 2016 at 8:31 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> On Sun, May 15, 2016 at 6:57 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>> The double-loop wants to do an early return immediately when one
>>> matching macro is found.  Eliminate the extra variable 'a' used for
>>> that purpose and rewrite the "assign found itme to 'a' to make it
>>
>> What's "itme"?
>
> item.

The code looks good.

Thanks,
Stefan