Re: [PATCH v1 1/2] log -G: Ignore binary files

From: Stefan Beller <sbeller@google.com>
Date: Nov 26, 2018, 20:19 UTC
Message-ID: <CAGZ79kaaLeaffMnkyd7Z1gF5yxq=GDH_Fy_PG1=FfcL=9b9nRQ@mail.gmail.com>
In-Reply-To: <590f2ca6b5323c17365a1645b5d10e9ab30623c4.1542833244.git.thomas.braun@virtuell-zuhause.de>

On Wed, Nov 21, 2018 at 1:08 PM Thomas Braun <thomas.braun@virtuell-zuhause.de> wrote:

Show 6 quoted lines

>
> The -G <regex> option of log looks for the differences whose patch text
> contains added/removed lines that match regex.
>
> The concept of differences only makes sense for text files, therefore
> we need to ignore binary files when searching with -G <regex> as well.

What about partial text/partial binary files?

I recall using text searching tools (not necessarily git machinery, my memory is fuzzy) to check for strings in pdf files, which are usually marked binary in context of git, such that we do not see their diffs in `log -p`.

But I would expect a search with -G or -S to still work... until I find the exception in the docs, only to wonder if there is a switch to turn off this optimisation for this corner case.

Stefan