Re: [PATCH 1/4] push options: {pre,post}-receive hook learns about push options

From: Stefan Beller <sbeller@google.com>
Date: Jul 1, 2016, 19:50 UTC
Message-ID: <CAGZ79kaRG7SOcz1LyOkN8W_dpmK_AjwYyyMrZftZCac9fCo+EQ@mail.gmail.com>
In-Reply-To: <20160701193909.GA23141@sigill.intra.peff.net>

On Fri, Jul 1, 2016 at 12:39 PM, Jeff King <peff@peff.net> wrote:

>
> That was sort of my question. _Is it_ too bad or not? It's hard to say
> without knowing the use cases.
>

...

>
> That's ugly, of course, but not really uglier than the parsing required
> for the COUNT proposal.

ok, I'll try to get the COUNT proposal in good enough shape.

Show 6 quoted lines

>
> I'm assuming that git actually knows about and enforces that things are
> "key=value". I'm not sure how you'd get by without that (you'd have to
> infer the meaning of a parameter by its position, which seems like a
> recipe for mistakes and incompatibilities).
>

Of course! We could use "a hack" just like in the Git config itself. If a boolean parameter is not given, the default is assumed. If it is given the opposite is assumed. Same for attributes, that can be set by just giving the key (with no "=true").

So I think I can be convinced to go only with key/value pairs for now, but it would be easier if you'd just have

    git push -o draft ...