git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/3] {fetch,upload}-pack: support filter in protocol v2

From
Stefan Beller <sbeller@google.com>
Date
May 3, 2018, 20:15 UTC
Message-ID
<CAGZ79kaHHNVW+Mj=RkQsWmc1ta1GPRLQaZR7aEDe6PAr_7wD+Q@mail.gmail.com>
In-Reply-To
<38aae093ffc23f886ab4aaeff72eae5e7c794df0.1525220786.git.jonathantanmy@google.com>
Hi Jonathan,
On Tue, May 1, 2018 at 5:31 PM, Jonathan Tan <jonathantanmy@google.com> wrote:
Show 11 quoted lines
> The fetch-pack/upload-pack protocol v2 was developed independently of
> the filter parameter (used in partial fetches), thus it did not include
> support for it. Add support for the filter parameter.
>
> Like in the legacy protocol, the server advertises and supports "filter"
> only if uploadpack.allowfilter is configured.
>
> Like in the legacy protocol, the client continues with a warning if
> "--filter" is specified, but the server does not advertise it.
>
> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
The whole series looks good,

Thanks, Stefan

Previous: Jonathan TanNext: Jonathan Tan
Message 16 of 20 in “Supporting partial clones in protocol v2”
  1. 0/2 Supporting partial clones in protocol v2Jonathan Tan, May 1, 2018
  2. 1/2 upload-pack: fix error message typoJonathan Tan, May 1, 2018
  3. Jonathan TanMay 1, 2018
  4. 2/2 {fetch,upload}-pack: support filter in protocol v2Jonathan Tan, May 1, 2018
  5. Brandon WilliamsMay 1, 2018
  6. 0/3 Supporting partial clones in protocol v2Jonathan Tan, May 2, 2018
  7. 1/3 upload-pack: fix error message typoJonathan Tan, May 2, 2018
  8. Stefan BellerMay 3, 2018
  9. Jonathan TanMay 3, 2018
  10. Junio C HamanoMay 4, 2018
  11. Jonathan TanMay 4, 2018
  12. 2/3 upload-pack: read config when serving protocol v2Jonathan Tan, May 2, 2018
  13. Stefan BellerMay 3, 2018
  14. Jonathan TanMay 3, 2018
  15. 3/3 {fetch,upload}-pack: support filter in protocol v2Jonathan Tan, May 2, 2018
  16. Stefan BellerMay 3, 2018
  17. 0/3 Supporting partial clones in protocol v2Jonathan Tan, May 3, 2018
  18. 1/3 upload-pack: fix error message typoJonathan Tan, May 3, 2018
  19. 2/3 upload-pack: read config when serving protocol v2Jonathan Tan, May 3, 2018
  20. 3/3 {fetch,upload}-pack: support filter in protocol v2Jonathan Tan, May 3, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.