From: Stefan Beller <sbeller@google.com>
Date: Thu, 03 May 2018 20:15:48 GMT
Subject: Re: [PATCH v2 3/3] {fetch,upload}-pack: support filter in protocol v2
Message-ID: <CAGZ79kaHHNVW+Mj=RkQsWmc1ta1GPRLQaZR7aEDe6PAr_7wD+Q@mail.gmail.com>
In-Reply-To: <38aae093ffc23f886ab4aaeff72eae5e7c794df0.1525220786.git.jonathantanmy@google.com>

Hi Jonathan,

On Tue, May 1, 2018 at 5:31 PM, Jonathan Tan <jonathantanmy@google.com> wrote:
> The fetch-pack/upload-pack protocol v2 was developed independently of
> the filter parameter (used in partial fetches), thus it did not include
> support for it. Add support for the filter parameter.
>
> Like in the legacy protocol, the server advertises and supports "filter"
> only if uploadpack.allowfilter is configured.
>
> Like in the legacy protocol, the client continues with a warning if
> "--filter" is specified, but the server does not advertise it.
>
> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>

The whole series looks good,

Thanks,
Stefan