Re: [PATCH 1/2] submodule-config: keep shallow recommendation around

From: Stefan Beller <sbeller@google.com>
Date: May 26, 2016, 17:22 UTC
Message-ID: <CAGZ79kaFD=0ijNvs8B9V+KbhasqF1N6OoAVucR-Hf_hVN+b-dQ@mail.gmail.com>
In-Reply-To: <2022441346.44059.1464253372857.JavaMail.zimbra@ensimag.grenoble-inp.fr>

On Thu, May 26, 2016 at 2:02 AM, Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr> wrote:

Show 19 quoted lines

> Hi Stefan,
>
> Stefan Beller <sbeller@google.com> writes:
>> [...]
>> @ -353,6 +354,15 @@ static int parse_config(const char *var, const char *value, void *data)
>>                  else if (parse_submodule_update_strategy(value,
>>                           &submodule->update_strategy) < 0)
>>                                  die(_("invalid value for %s"), var);
>> +        } else if (!strcmp(item.buf, "shallow")) {
>> +                if (!me->overwrite &&
>> +                         submodule->recommend_shallow != -1)
>
> Nit: You seems to be able to keep the whole condition on the same line:
>
>                 if (!me->overwrite && submodule->recommend_shallow != -1)
>
> If you want to keep it in two line, you might want to align it:
>                 if (!me->overwrite &&
>                     submodule->recommend_shallow != -1)

Thanks will fix!

>
> Thanks,
> Rémi